[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 13/16] block: Implement bdrv_append() without
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 13/16] block: Implement bdrv_append() without bdrv_swap() |
|
Date: |
Fri, 9 Oct 2015 15:54:45 +0100 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Oct 01, 2015 at 03:13:31PM +0200, Kevin Wolf wrote:
> +static void change_parent_backing_link(BlockDriverState *from,
> + BlockDriverState *to)
> +{
> + BdrvChild *c, *next;
> +
> + QLIST_FOREACH_SAFE(c, &from->parents, next_parent, next) {
I find the name "c" confusing because it reminds me of children rather
than the parents list.
Perhaps "parent" would be clearer here.
- [Qemu-devel] [PATCH v2 00/16] block: Get rid of bdrv_swap(), Kevin Wolf, 2015/10/08
- [Qemu-devel] [PATCH v2 11/16] block-backend: Add blk_set_bs(), Kevin Wolf, 2015/10/08
- [Qemu-devel] [PATCH v2 15/16] block: Add and use bdrv_replace_in_backing_chain(), Kevin Wolf, 2015/10/08
- [Qemu-devel] [PATCH v2 03/16] blkverify: Convert s->test_file to BdrvChild, Kevin Wolf, 2015/10/08
- [Qemu-devel] [PATCH v2 06/16] block: Remove bdrv_open_image(), Kevin Wolf, 2015/10/08
- [Qemu-devel] [PATCH v2 13/16] block: Implement bdrv_append() without bdrv_swap(), Kevin Wolf, 2015/10/08
- [Qemu-devel] [PATCH v2 16/16] block: Remove bdrv_swap(), Kevin Wolf, 2015/10/08
- [Qemu-devel] [PATCH v2 08/16] block: Manage backing file references in bdrv_set_backing_hd(), Kevin Wolf, 2015/10/08
- [Qemu-devel] [PATCH v2 07/16] block: Convert bs->backing_hd to BdrvChild, Kevin Wolf, 2015/10/08