[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 05/14] qapi: Lazy creation of array types
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v7 05/14] qapi: Lazy creation of array types |
Date: |
Sat, 10 Oct 2015 14:16:26 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/07/2015 10:38 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>
>> Commit ac88219a had several TODO markers about whether we needed
>> to automatically create the corresponding array type alongside
>> any other type. It turns out that most of the time, we don't!
>>
>> + def _make_simple_variant(self, case, typ, info):
>> if isinstance(typ, list):
>> assert len(typ) == 1
>> - typ = self._make_array_type(typ[0])
>> - typ = self._make_implicit_object_type(typ, 'wrapper',
>> - [self._make_member('data',
>> typ)])
>> + typ = self._make_array_type(typ[0], info)
>> + typ = self._make_implicit_object_type(
>> + typ, 'wrapper', [self._make_member('data', typ, info)])
>
> I'd indent the hanging intent a bit more, to make the = stand out.
pep8 doesn't like it:
scripts/qapi.py:1299:17: E126 continuation line over-indented for
hanging indent
but it was okay with:
type = (self._make_implicit_object_type(
type, ...))
and that does look a little better.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v7 13/14] qapi: Add test for alternate branch 'kind' clash, Eric Blake, 2015/10/08
[Qemu-devel] [PATCH v7 03/14] qapi: Drop redundant alternate-good test, Eric Blake, 2015/10/08
[Qemu-devel] [PATCH v7 01/14] qapi: Use predicate callback to determine visit filtering, Eric Blake, 2015/10/08
[Qemu-devel] [PATCH v7 08/14] qapi: Track location that created an implicit type, Eric Blake, 2015/10/08