qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] ivshmem-test: Implement tests


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH 2/2] ivshmem-test: Implement tests
Date: Sun, 11 Oct 2015 00:28:30 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

Am 11.10.2015 um 00:18 schrieb Andreas Färber:
> diff --git a/tests/Makefile b/tests/Makefile
> index 3b7e6ac..324829b 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -146,6 +146,8 @@ gcov-files-pci-y += hw/display/virtio-gpu-pci.c
>  gcov-files-pci-$(CONFIG_VIRTIO_VGA) += hw/display/virtio-vga.c
>  check-qtest-pci-y += tests/intel-hda-test$(EXESUF)
>  gcov-files-pci-y += hw/audio/intel-hda.c hw/audio/hda-codec.c
> +check-qtest-pci-$(CONFIG_LINUX) += tests/ivshmem-test$(EXESUF)
> +gcov-files-pci-y += hw/misc/ivshmem.c
>  
>  check-qtest-i386-y = tests/endianness-test$(EXESUF)
>  check-qtest-i386-y += tests/fdc-test$(EXESUF)
> @@ -191,8 +193,6 @@ gcov-files-i386-y += hw/pci-host/q35.c
>  ifeq ($(CONFIG_VHOST_NET),y)
>  check-qtest-i386-$(CONFIG_LINUX) += tests/vhost-user-test$(EXESUF)
>  endif
> -check-qtest-i386-y += tests/ivshmem-test$(EXESUF)
> -gcov-files-i386-y += i386-softmmu/hw/misc/ivshmem.c
>  check-qtest-x86_64-y = $(check-qtest-i386-y)
>  gcov-files-i386-y += i386-softmmu/hw/timer/mc146818rtc.c
>  gcov-files-x86_64-y = $(subst 
> i386-softmmu/,x86_64-softmmu/,$(gcov-files-i386-y))
[snip]

This is a quick rebase onto the last version of my older patch. I notice
that the gcov path is different: hw/misc/Makefile.objs has it in obj-y,
not common-obj-y; the .c path counter-intuitively needs to match the .o
file, not the .c file.

Untested whether adding i386-softmmu/ prefix would work for
check-qtest-pci-y, too.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]