[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] [RFC] arm_gic_common.h: add gicv2 aliases f
|
From: |
Pavel Fedin |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] [RFC] arm_gic_common.h: add gicv2 aliases for defines |
|
Date: |
Mon, 12 Oct 2015 09:58:12 +0300 |
Hi!
> It looks like the only thing in the gicv3 code that is using
> a define from the arm_gic_common.h file is "GIC_INTERNAL",
> so we can just put a suitable define of that into the v3 header
> (maybe giving it a better name in the process).
Yes, indeed. Actually, first versions of my GICv3 patches did use own #define,
but i was criticized for using GICV3_INTERNAL in my code and having
GIC_INTERNAL in kvm_arm_gic_set_irq(), which is shared by both KVM
implementations. So, i decided to use GIC_INTERNAL everywhere and inherited it
from v2.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia