Re: [Qemu-devel] [RFC v1 2/2] spapr: Force gaps between DIMM's GPA

[Igor Mammedov]

On Fri,  9 Oct 2015 12:20:00 +0530
Bharata B Rao <address@hidden> wrote:

> Mapping DIMMs non contiguously allows to workaround virtio bug
> reported earlier:
> http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg00522.html
> In this case guest kernel doesn't allocate buffers that can cross DIMM
> boundary keeping each buffer local to a DIMM.
> 
> Suggested-by: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Bharata B Rao <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>

> ---
>  hw/ppc/spapr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 4a901f0..a66833f 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -2137,7 +2137,7 @@ static void spapr_memory_plug(HotplugHandler
> *hotplug_dev, DeviceState *dev, goto out;
>      }
>  
> -    pc_dimm_memory_plug(dev, &ms->hotplug_memory, mr, align, false,
> &local_err);
> +    pc_dimm_memory_plug(dev, &ms->hotplug_memory, mr, align, true,
> &local_err); if (local_err) {
>          goto out;
>      }