qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 14/21] qemu-char: convert braille backend to dat


From: Samuel Thibault
Subject: Re: [Qemu-devel] [PATCH 14/21] qemu-char: convert braille backend to data-driven creation
Date: Mon, 12 Oct 2015 17:41:35 +0200
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Eric Blake, le Mon 12 Oct 2015 09:30:12 -0600, a écrit :
>  Also, I assume that brlapi_perror() adds additional information to
> the error message it prints, such as conversion of a brlapi-specific
> error message in the same manner in which perror() converts errno and in
> which error_setg_errno() would be used.

Yes. Such additional information is really useful to debug brlapi
issues.

> So I don't know if this
> conversion is the best.  But I'm unfamiliar with brlapi_* in general, to
> know if there is anything better to use,

brlapi_error_t * brlapi_error_location(void);
const char * brlapi_strerror(const brlapi_error_t *error);

So brlapi_strerror(brlapi_error_location()) will return what you want,
i.e. the string that brlapi_error() would have printed.

> so I'd rather get a second opinion on this.

Cc-ing me would have been useful, "braille" just happened to catch my
eye by luck while looking over qemu mails :)

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]