[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 04/26] target-*: Introduce and use cpu_breakpoint
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PULL 04/26] target-*: Introduce and use cpu_breakpoint_test |
|
Date: |
Tue, 13 Oct 2015 09:13:08 +0100 |
On 13 October 2015 at 01:13, Richard Henderson <address@hidden> wrote:
> Why do you believe that a zero-length TB won't be cleared?
> The TB still has a start address, which is contained within
> a given page, which is invalidated.
>
> Some target-*/translate.c takes care to advance the PC, but I believe that
> this is only required when the breakpoint instruction *itself* could span a
> page boundary. I.e. the TB needs to be marked to span two pages. This
> situation can never be true for many RISC targets.
If this is the reason for the logic it would be good to have
a comment explaining it in the code. I've never really understood
that part...
-- PMM
[Qemu-devel] [PULL 03/26] target-*: Increment num_insns immediately after tcg_gen_insn_start, Richard Henderson, 2015/10/08
[Qemu-devel] [PULL 06/26] target-arm: Add condexec state to insn_start, Richard Henderson, 2015/10/08
[Qemu-devel] [PULL 05/26] tcg: Allow extra data to be attached to insn_start, Richard Henderson, 2015/10/08
[Qemu-devel] [PULL 13/26] target-sparc: Split out gen_branch_n, Richard Henderson, 2015/10/08
[Qemu-devel] [PULL 16/26] tcg: Merge cpu_gen_code into tb_gen_code, Richard Henderson, 2015/10/08
[Qemu-devel] [PULL 10/26] target-sh4: Add flags state to insn_start, Richard Henderson, 2015/10/08
[Qemu-devel] [PULL 22/26] tcg: Remove tcg_gen_code_search_pc, Richard Henderson, 2015/10/08
[Qemu-devel] [PULL 18/26] tcg: Add TCG_MAX_INSNS, Richard Henderson, 2015/10/08