[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 05/12] block: Introduce "drained begin/end" A
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 05/12] block: Introduce "drained begin/end" API |
|
Date: |
Tue, 13 Oct 2015 13:12:46 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 13.10.2015 um 12:39 hat Paolo Bonzini geschrieben:
>
>
> On 13/10/2015 11:31, Kevin Wolf wrote:
> > This would mean that once you've sent an I/O request inside a drain
> > section, you have to expect that more internal I/O might be going on
> > after the request has completed. If you don't want this, you have to
> > issue another bdrv_drain() or use a nested bdrv_drained_begin/end()
> > section.
>
> Yes.
>
> > Sounds reasonable enough to me, but I guess this should be explicitly
> > documented.
>
> I agree. Perhaps bdrv_drained_begin/end() could be renamed to
> bdrv_drain_and_lock() / bdrv_unlock()?
It's not very obvious what bdrv_unlock() refers to, so I prefer the
current naming. Just making sure that the comment for bdrv_drained_begin
explains the exact semantics should be good enough.
Kevin
[Qemu-devel] [PATCH v2 06/12] block: Add "drained begin/end" for transactional external snapshot, Fam Zheng, 2015/10/12
[Qemu-devel] [PATCH v2 08/12] block: Add "drained begin/end" for transactional blockdev-backup, Fam Zheng, 2015/10/12
[Qemu-devel] [PATCH v2 10/12] block: Introduce BlockDriver.bdrv_drain callback, Fam Zheng, 2015/10/12
[Qemu-devel] [PATCH v2 12/12] tests: Add test case for aio_disable_external, Fam Zheng, 2015/10/12
[Qemu-devel] [PATCH v2 11/12] qed: Implement .bdrv_drain, Fam Zheng, 2015/10/12
[Qemu-devel] [PATCH v2 04/12] aio: introduce aio_{disable, enable}_external, Fam Zheng, 2015/10/15
[Qemu-devel] [PATCH v2 07/12] block: Add "drained begin/end" for transactional backup, Fam Zheng, 2015/10/15
[Qemu-devel] [PATCH v2 09/12] block: Add "drained begin/end" for internal snapshot, Fam Zheng, 2015/10/15