Re: [Qemu-devel] [PATCH v4 0/7] qom: more efficient object property handling

[Daniel P. Berrange]

On Tue, Oct 13, 2015 at 02:54:14PM +0200, Andreas Färber wrote:
> Daniel,
> 
> Am 13.10.2015 um 14:37 schrieb Daniel P. Berrange:
> > This patch series is a followup to
> > 
> >  v3: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg02024.html
> >  v2: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg05953.html
> >      +
> >      https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg01455.html
> > 
> > This series introduces a concept of object property iterators
> > to QOM so callers are insulated from the specific data structures
> > used for storing properties against objects/classes. It then
> > converts Object to use a GHashTable for storing properties.
> > Finally it introduces ObjectClass properties.
> > 
> > Probably the only controversial thing is the item Pavel points
> > out about object_child_foreach iterators now being forbidden
> > from modifying the object composition tree.
> 
> Before this grows even larger, can't we just apply your v2 and go on
> from there? I had reviewed that okay, just have it in my to-test queue...

I don't mind either way - if you want to queue my v2 I can rebase on
top of that. Just beware though that my v2 had a latent bug that will
trigger when any code starts to use class level properties - they don't
get reported by QMP. So we'd have to make sure to apply this new series
I have posted in order to fix that bug before we convert any code to
use class props.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|