Re: [Qemu-devel] [PATCH 0/3] Make KVM/MSI code device-ID-aware

[Pavel Fedin]

 Hello!

> I'm not at all sure we want to keep extending pci-assign with
> more functionality. Why not add it to vfio instead?

 pci-assign? What exactly do you mean?

 hw/i386/kvm/pci-assign.c is modified only because kvm_irqchip_add_msi_route() 
now wants pci_dev pointer. Since x86 platform doesn't
use device IDs, it could very well be NULL. Just i decided to keep it 
consistent with the rest of the code.
 Actually, patch 0003 is all about that - we add pci_dev pointer to KVM GSI 
routing functions and make callers passing it, that's
all. Currently it's not used because KVM API is not released yet. See my full 
vITS patchset for information on how it will be used.
And yes, the patchset is a bit obsolete, so it doesn't have msi_device_id() 
inline, there's copypasted calculation instead.
 What exactly do you suggest to move to vfio?

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia