[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v3 05/51] ivshmem: fix number of bytes to push to fif
From: |
marcandre . lureau |
Subject: |
[Qemu-devel] [PULL v3 05/51] ivshmem: fix number of bytes to push to fifo |
Date: |
Tue, 13 Oct 2015 16:25:32 +0200 |
From: Marc-André Lureau <address@hidden>
If the fifo has 0 bytes, and the read is of size 1, the call to
fifo8_push_all() will copy off boundary data.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Claudio Fontana <address@hidden>
---
hw/misc/ivshmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index fb53b3f..2162d02 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -455,7 +455,7 @@ static void ivshmem_read(void *opaque, const uint8_t *buf,
int size)
uint32_t num;
IVSHMEM_DPRINTF("short read of %d bytes\n", size);
- num = MAX(size, sizeof(long) - fifo8_num_used(&s->incoming_fifo));
+ num = MIN(size, sizeof(long) - fifo8_num_used(&s->incoming_fifo));
fifo8_push_all(&s->incoming_fifo, buf, num);
if (fifo8_num_used(&s->incoming_fifo) < sizeof(incoming_posn)) {
return;
--
2.4.3
- [Qemu-devel] [PULL v3 00/51] Ivshmem patches, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v3 01/51] tests: Add ivshmem qtest, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 02/51] char: add qemu_chr_free(), marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 03/51] msix: add VMSTATE_MSIX_TEST, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 04/51] ivhsmem: read do not accept more than sizeof(long), marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 05/51] ivshmem: fix number of bytes to push to fifo,
marcandre . lureau <=
- [Qemu-devel] [PULL v3 06/51] ivshmem: factor out the incoming fifo handling, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 08/51] ivshmem: remove superflous ivshmem_attr field, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 09/51] ivshmem: remove useless doorbell field, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 07/51] ivshmem: remove unnecessary dup(), marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 10/51] ivshmem: more qdev conversion, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 11/51] ivshmem: remove last exit(1), marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 15/51] ivshmem: remove useless ivshmem_update_irq() val argument, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 18/51] ivshmem: improve debug messages, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 17/51] ivshmem: remove max_peer field, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 21/51] ivshmem: simplify a bit the code, marcandre . lureau, 2015/10/13