Re: [Qemu-devel] [PATCH v3 03/32] acpi: add aml_create_field

[Xiao Guangrong]

On 10/13/2015 08:38 PM, Igor Mammedov wrote:
> On Sun, 11 Oct 2015 11:52:35 +0800
> Xiao Guangrong <address@hidden> wrote:
>
> > Implement CreateField term which is used by NVDIMM _DSM method in later patch
> >
> > Signed-off-by: Xiao Guangrong <address@hidden>
> > ---
> >   hw/acpi/aml-build.c         | 13 +++++++++++++
> >   include/hw/acpi/aml-build.h |  1 +
> >   2 files changed, 14 insertions(+)
> >
> > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> > index a72214d..9fe5e7b 100644
> > --- a/hw/acpi/aml-build.c
> > +++ b/hw/acpi/aml-build.c
> > @@ -1151,6 +1151,19 @@ Aml *aml_sizeof(Aml *arg)
> >       return var;
> >   }
> >
> > +/* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefCreateField */
> > +Aml *aml_create_field(Aml *srcbuf, Aml *index, Aml *len, const char *name)
> you haven't addressed v2 comment wrt index, len
>   https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00435.html

Ah, i forgot to mention that the index/len can be determined at runtime:

aml_append(_method_, aml_create_field(aml_name("ODAT"), aml_int(0),\
                                      aml_local(6) , "OBUF"));
That why i kept these as "aml *" and sorry for i failed to log it
in patch 0.