[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 0/7] qom: more efficient object property hand
From: |
Pavel Fedin |
Subject: |
Re: [Qemu-devel] [PATCH v4 0/7] qom: more efficient object property handling |
Date: |
Wed, 14 Oct 2015 09:57:48 +0300 |
Hello!
> This series introduces a concept of object property iterators
> to QOM so callers are insulated from the specific data structures
> used for storing properties against objects/classes. It then
> converts Object to use a GHashTable for storing properties.
> Finally it introduces ObjectClass properties.
Tested-by: Pavel Fedin <address@hidden>
> Probably the only controversial thing is the item Pavel points
> out about object_child_foreach iterators now being forbidden
> from modifying the object composition tree.
As i already wrote, current code does not modify the tree. If necessary, it is
possible to work around (e. g. make a decision about modification, stop
iteration, then do the modification). I think this would pop up anyway if we
change list to anything else. IMHO it's better just to acknowledge that we
should not modify our tree inside iterator.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
- [Qemu-devel] [PATCH v4 0/7] qom: more efficient object property handling, Daniel P. Berrange, 2015/10/13
- [Qemu-devel] [PATCH v4 2/7] qmp: convert QMP code to use object property iterators, Daniel P. Berrange, 2015/10/13
- [Qemu-devel] [PATCH v4 5/7] net: convert net filter code to use object property iterators, Daniel P. Berrange, 2015/10/13
- [Qemu-devel] [PATCH v4 3/7] vl: convert machine help code to use object property iterators, Daniel P. Berrange, 2015/10/13
- [Qemu-devel] [PATCH v4 7/7] qom: allow properties to be registered against classes, Daniel P. Berrange, 2015/10/13
- [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable, Daniel P. Berrange, 2015/10/13
- Re: [Qemu-devel] [PATCH v4 0/7] qom: more efficient object property handling, Andreas Färber, 2015/10/13
- Re: [Qemu-devel] [PATCH v4 0/7] qom: more efficient object property handling,
Pavel Fedin <=
- [Qemu-devel] [PATCH v4 1/7] qom: introduce ObjectPropertyIterator struct for iteration, Daniel P. Berrange, 2015/10/15
- [Qemu-devel] [PATCH v4 4/7] ppc: convert spapr code to use object property iterators, Daniel P. Berrange, 2015/10/15