qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v8 15/18] qapi: Move duplicate member checks to


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v8 15/18] qapi: Move duplicate member checks to schema check()
Date: Wed, 14 Oct 2015 09:11:22 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Eric Blake <address@hidden> writes:

> On 10/13/2015 02:17 PM, Eric Blake wrote:
>
>>>>> I can take PATCH 01-09,12 into my tree right away, with PATCH 07's two
>>>>> redundant is_implicit() methods dropped, and PATCH 12's comment touched
>>>>> up.
>>>>
>>>> Okay.
>>>
>>> Done & pushed to http://repo.or.cz/qemu/armbru.git branch qapi-next.
>> 
>> I didn't see any mentioned changes on patch 7, at least not in commit
>> 4ad5066.  Last paragraph of the commit message would also need a
>> massage, if you do want to squash it in:

I messed it up, fixing :)

> And of course, if you move the hunks out of 7, then they DO need to be
> added back into 12, since it is 12 that provides non-None info on
> implicit types (not seen in commit 20bfea1).

Yup.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]