[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] doc/rcu: fix g_free_rcu() usage example
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] doc/rcu: fix g_free_rcu() usage example |
Date: |
Wed, 14 Oct 2015 17:47:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 14/10/2015 17:46, Sergey Fedorov wrote:
> The first argument of g_free_rcu() is a pointer to a structure. But
> foo_reclaim is used as a function name in the previous example along
> with &foo as a pointer to the structure being reclaimed. Make the
> example consistent with the previous one.
>
> Signed-off-by: Sergey Fedorov <address@hidden>
> ---
> docs/rcu.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/rcu.txt b/docs/rcu.txt
> index 21ecb81..2f70954 100644
> --- a/docs/rcu.txt
> +++ b/docs/rcu.txt
> @@ -128,7 +128,7 @@ The core RCU API is small:
> the callback function is g_free, in particular, g_free_rcu can be
> used. In the above case, one could have written simply:
>
> - g_free_rcu(foo_reclaim, rcu);
> + g_free_rcu(&foo, rcu);
>
> typeof(*p) atomic_rcu_read(p);
>
>
Thanks, I've queued this patch, and I hope to send it out on Friday.
Paolo