[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] qapi: Fix regression with '-netdev ?'
From: |
Eric Blake |
Subject: |
[Qemu-devel] [PATCH] qapi: Fix regression with '-netdev ?' |
Date: |
Wed, 14 Oct 2015 10:30:29 -0600 |
Commit e36c714e causes 'qemu -netdev ?' to dump core, because the
call to visit_end_union() is no longer conditional on whether
*obj was allocated.
Reported by Marc-André Lureau <address@hidden>
Signed-off-by: Eric Blake <address@hidden>
---
scripts/qapi-visit.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py
index 9e99c3a..74748a2 100644
--- a/scripts/qapi-visit.py
+++ b/scripts/qapi-visit.py
@@ -297,7 +297,9 @@ void visit_type_%(c_name)s(Visitor *v, %(c_name)s **obj,
const char *name, Error
out_obj:
error_propagate(errp, err);
err = NULL;
- visit_end_union(v, !!(*obj)->u.data, &err);
+ if (*obj) {
+ visit_end_union(v, !!(*obj)->u.data, &err);
+ }
error_propagate(errp, err);
err = NULL;
visit_end_struct(v, &err);
--
2.4.3
- [Qemu-devel] [PATCH] qapi: Fix regression with '-netdev ?',
Eric Blake <=