[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -
From: |
OGAWA Hirofumi |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode |
Date: |
Thu, 15 Oct 2015 17:24:01 +0900 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
Gerd Hoffmann <address@hidden> writes:
>> vga_to_curses[] is filled by curses_setup(). So if no -curses option, I
>> think it should have no change to behavior. (BTW, there is no common
>> section like kernel in qemu build, right? i.e. no need initializer to
>> global value.)
>
> Ok, curses and gtk can't be active at the same time. But for curses and
> vnc it is possible (qemu -curses -vnc :$display), and you probably get a
> dissorted vga text mode over vnc then.
>
> I think the mapping should happen in the curses code, when curses
> updates the screen. curses_update() function is probably the best place
> for it.
OK. It would be possible though, but parsing at curses_update() is
slower. It is why, I did at that. Well, I'll see.
> Also you don't need a init function, you can simply init the array with
> c99 initializers:
>
> chtype vga_to_curses[256] = {
> [0x04] = ACS_DIAMOND,
> [ ... ]
> };
This is not possible, because ACS_* is not constant (initialized by
reading from termcap or such).
Thanks.
--
OGAWA Hirofumi <address@hidden>
- [Qemu-devel] [RFC 0/3] improve/fix -curses mode, OGAWA Hirofumi, 2015/10/14
- [Qemu-devel] [PATCH 1/3] ui/curses: Fix monitor color with -curses when 256 colors, OGAWA Hirofumi, 2015/10/15
- [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/14
- [Qemu-devel] [PATCH 3/3] ui/curses: Fix pageup/pagedown on -curses, OGAWA Hirofumi, 2015/10/14
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Eric Blake, 2015/10/14
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/14
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/14
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/14
- [Qemu-devel] [PATCH v2 1/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/14
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode,
OGAWA Hirofumi <=
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- [Qemu-devel] [PATCH v3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/19
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/19
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- [Qemu-devel] [PATCH v4] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
Re: [Qemu-devel] [RFC 0/3] improve/fix -curses mode, Markus Armbruster, 2015/10/15