Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode

[Gerd Hoffmann]

  Hi,

> From this call paths, graphic_hw_text_update() => console_write_ch() =>
> ->text_update() path is only used for -curses mode. What do you think?

Oh, right, text mode curses update and text mode framebuffer rendering
take completely separate code paths.  Completely forgot that, I rarely
look into the curses code.  Sorry for the extra trouble.

> (E.g. qemu is going to extend to use this for other purpose?)

Unlikely.  In theory other ui frontends could support vga text mode that
way.  But text mode is a dying relic, people use either graphics or a
serial console these days, so I don't expect that to happen.

So, I still think it would be cleaner to implement the curses special
char mapping in ui/curses.c.  I can't imagine there is a noticable
performance difference.  But doing it like you did shouldn't break
things either.

cheers,
  Gerd