qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -


From: OGAWA Hirofumi
Subject: Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode
Date: Thu, 15 Oct 2015 18:54:20 +0900
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

Gerd Hoffmann <address@hidden> writes:

>> (E.g. qemu is going to extend to use this for other purpose?)
>
> Unlikely.  In theory other ui frontends could support vga text mode that
> way.  But text mode is a dying relic, people use either graphics or a
> serial console these days, so I don't expect that to happen.
>
> So, I still think it would be cleaner to implement the curses special
> char mapping in ui/curses.c.  I can't imagine there is a noticable
> performance difference.  But doing it like you did shouldn't break
> things either.

OK. For cleaner (purpose is separation of curses code), I introduced
hw_text_update_cb() interface (looks like possible to use text data for
other than curses interface too). But you may feel this is overkill.

Well, IMO, the patch makes clear purpose of this path in following reply.

Thanks.
-- 
OGAWA Hirofumi <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]