[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 3/3] kvm: Pass PCI device pointer to MSI rout
|
From: |
Pavel Fedin |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 3/3] kvm: Pass PCI device pointer to MSI routing functions |
|
Date: |
Thu, 15 Oct 2015 14:59:13 +0300 |
Hello!
> Should the pci_dev be passed to kvm_arch_fixup_msi_route() as well?
> Currently, the only implementer of this function (s390x) does not need
> it; but it shouldn't hurt?
Yes, it shouldn't. I didn't pass it there exactly because of this reason.
However, &kroute is also passed to this function, so
setting ARM-specific data could be moved there. I mean this repeating sequence
(see vITS RFC 4/6 -
https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg07075.html):
--- cut ---
kroute.flags = kvm_msi_flags;
if (kroute.flags & KVM_MSI_VALID_DEVID) {
kroute.u.msi.devid = pci_requester_id(dev);
}
--- cut ---
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia