[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 06/22] block: Add "supports_stats" field to B
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH v2 06/22] block: Add "supports_stats" field to BlockStats |
Date: |
Thu, 15 Oct 2015 15:06:19 +0200 |
User-agent: |
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) |
On Tue 13 Oct 2015 05:38:30 PM CEST, Stefan Hajnoczi wrote:
>> query-blockstats always returns a BlockDeviceStats structure for each
>> BDS, regardless of whether it implements accounting or not. Since the
>> field is mandatory there's no way to tell that from the values alone.
>>
>> This field solves that problem by indicating which BDSs support I/O
>> accounting.
>
> I'm not sure I understand the problem.
>
> If I/O accounting isn't being used then all fields will be 0?
Yes, but there's no way to tell if that happens because I/O accounting
is not supported or because there hasn't been any I/O yet.
There's one additional problem: this patch assumes that accounting is
supported if this BDS is attached to a BlockBackend. But we don't know
if the device model supports accounting or not, I still need to figure
out what's the best way to do it.
Berto
- [Qemu-devel] [PATCH v2 16/22] virtio-blk: Account for failed and invalid operations, (continued)
- [Qemu-devel] [PATCH v2 16/22] virtio-blk: Account for failed and invalid operations, Alberto Garcia, 2015/10/08
- [Qemu-devel] [PATCH v2 01/22] xen_disk: Account for flush operations, Alberto Garcia, 2015/10/08
- [Qemu-devel] [PATCH v2 04/22] util: Infrastructure for computing recent averages, Alberto Garcia, 2015/10/08
- [Qemu-devel] [PATCH v2 22/22] block: Update copyright of the accounting code, Alberto Garcia, 2015/10/08
- [Qemu-devel] [PATCH v2 05/22] block: Add idle_time_ns to BlockDeviceStats, Alberto Garcia, 2015/10/08
- [Qemu-devel] [PATCH v2 06/22] block: Add "supports_stats" field to BlockStats, Alberto Garcia, 2015/10/08
[Qemu-devel] [PATCH v2 07/22] block: Add statistics for failed and invalid I/O operations, Alberto Garcia, 2015/10/08
[Qemu-devel] [PATCH v2 03/22] block: define 'clock_type' for the accounting code, Alberto Garcia, 2015/10/08
[Qemu-devel] [PATCH v2 09/22] block: Compute minimum, maximum and average I/O latencies, Alberto Garcia, 2015/10/08
[Qemu-devel] [PATCH v2 11/22] block: New option to define the intervals for collecting I/O statistics, Alberto Garcia, 2015/10/08