[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] fw_cfg: insert string blobs via qemu cmdline
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH v4] fw_cfg: insert string blobs via qemu cmdline |
Date: |
Thu, 15 Oct 2015 17:50:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/15/15 11:24, Gerd Hoffmann wrote:
> On Mi, 2015-10-14 at 16:22 +0200, Laszlo Ersek wrote:
>> Paolo,
>>
>> On 09/29/15 18:29, Gabriel L. Somlo wrote:
>>> Allow users to provide custom fw_cfg blobs with ascii string
>>> payloads specified directly on the qemu command line.
>>>
>>> Suggested-by: Jordan Justen <address@hidden>
>>> Suggested-by: Laszlo Ersek <address@hidden>
>>> Signed-off-by: Gabriel Somlo <address@hidden>
>>> Reviewd-by: Laszlo Ersek <address@hidden>
>>> ---
>>>
>>> New since v3: s/content/string/g for the option name, at Gerd's
>>> suggestion (to potentially allow for additional content
>>> types directly on the command line, should the need arise
>>> at a future date)
>>>
>>> Thanks,
>>> --Gabriel
>>>
>>> docs/specs/fw_cfg.txt | 15 +++++++++++++++
>>> qemu-options.hx | 7 ++++++-
>>> vl.c | 33 +++++++++++++++++++++++++++------
>>> 3 files changed, 48 insertions(+), 7 deletions(-)
>>
>> I'm sure you're going to want to give me a hug for bringing this up, but
>> can you please pick this up? O:-)
>>
>> Or maybe Peter can apply it directly?
>
> I guess I'll go prepare a fw_cfg pull request, probably tomorrow.
> There also is the fw_cfg_dma series from Marc ...
Great, thanks!
>
> While being at it: anything else which is ready? The fw_cfg acpi
> patches seem still to be on discussion still ...
That's my impression as well, yes. And, in any case, Marc's work and
Gabriel's conflict (in context, not in purpose / implementation), so I
guess Gabriel will have to rebase (purely because Marc's work has
converged first).
Thanks!
Laszlo
>
> cheers,
> Gerd
>
>