Re: [Qemu-devel] [Qemu-discuss] TCP options ipv4 and ipv6 have no effect

[Sair, Umair]

Paolo, thanks for the explanation :)

> Did you test the patch, and did it work for you?  If so, it is customary to 
> reply with a line like "Tested by: Sair, Umair <address@hidden>".
Yes, it worked for me. Should I reply to the email containing the patch with 
the above line?

>> so I'll like to add one more thing
>> which requires to be fixed along with it. In 'tcp_chr_accept'
>> function of qemu-char.c, the data type of saddr should be
>> sockaddr_in6 so that it works with both IPv6 and IPv4 on Windows 
>> (works for linux without it because of accept4 and works with this 
>> solution as well!).
>
> Can you send a patch for it?

diff --git a/qemu-char.c b/qemu-char.c
index 653ea10..14966e9 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2985,7 +2985,7 @@ static gboolean tcp_chr_accept(GIOChannel *channel, GIOCon
 {
     CharDriverState *chr = opaque;
     TCPCharDriver *s = chr->opaque;
-    struct sockaddr_in saddr;
+    struct sockaddr_in6 saddr;
 #ifndef _WIN32
     struct sockaddr_un uaddr;
 #endif

Regards,
Umair Sair