[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/21] qemu-char: convert pipe backend to data-d
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 07/21] qemu-char: convert pipe backend to data-driven creation |
|
Date: |
Mon, 12 Oct 2015 17:18:48 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 12/10/2015 17:16, Eric Blake wrote:
>> rp)
>> > {
>> > + ChardevHostdev *opts = backend->pipe;
>> > int fd_in, fd_out;
>> > char filename_in[CHR_MAX_FILENAME_SIZE];
>> > char filename_out[CHR_MAX_FILENAME_SIZE];
>> > const char *filename = opts->device;
>> >
>> > - if (filename == NULL) {
>> > - fprintf(stderr, "chardev: pipe: no filename given\n");
>> > - return NULL;
>> > - }
>> > -
>> > snprintf(filename_in, CHR_MAX_FILENAME_SIZE, "%s.in", filename);
> Do we need assert(filename) here?
>
>
No, "device" is not optional in the definition of ChardevHostdev.
Paolo
- [Qemu-devel] [PATCH 21/21] qemu-char: cleanup after completed conversion to cd->create, (continued)
- [Qemu-devel] [PATCH 21/21] qemu-char: cleanup after completed conversion to cd->create, Paolo Bonzini, 2015/10/12
- [Qemu-devel] [PATCH 20/21] qemu-char: convert ringbuf backend to data-driven creation, Paolo Bonzini, 2015/10/12
- [Qemu-devel] [PATCH 18/21] qemu-char: convert spice backend to data-driven creation, Paolo Bonzini, 2015/10/12
- [Qemu-devel] [PATCH 01/21] qemu-char: cleanup qmp_chardev_add, Paolo Bonzini, 2015/10/15
- [Qemu-devel] [PATCH 07/21] qemu-char: convert pipe backend to data-driven creation, Paolo Bonzini, 2015/10/15
- [Qemu-devel] [PATCH 08/21] qemu-char: convert socket backend to data-driven creation, Paolo Bonzini, 2015/10/15
- [Qemu-devel] [PATCH 10/21] qemu-char: convert pty backend to data-driven creation, Paolo Bonzini, 2015/10/15
- [Qemu-devel] [PATCH 11/21] qemu-char: convert null backend to data-driven creation, Paolo Bonzini, 2015/10/15
- [Qemu-devel] [PATCH 14/21] qemu-char: convert braille backend to data-driven creation, Paolo Bonzini, 2015/10/15