[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v2 01/50] tests: Add ivshmem qtest
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PULL v2 01/50] tests: Add ivshmem qtest |
Date: |
Mon, 12 Oct 2015 20:00:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
Am 12.10.2015 um 18:40 schrieb address@hidden:
> From: Andreas Färber <address@hidden>
>
> Note that it launches two instances, as sharing memory is the purpose of
> ivshmem.
>
> Cc: Cam Macdonell <address@hidden>
> Cc: Marc-André Lureau <address@hidden>
> Signed-off-by: Andreas Färber <address@hidden>
> [ Remove Nahanni codename, add test to pci set - Marc-André ]
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> tests/Makefile | 3 +++
> tests/ivshmem-test.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 54 insertions(+)
> create mode 100644 tests/ivshmem-test.c
>
> diff --git a/tests/Makefile b/tests/Makefile
> index dbd32a6..c44b8de 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -149,6 +149,8 @@ gcov-files-pci-y += hw/display/virtio-gpu-pci.c
> gcov-files-pci-$(CONFIG_VIRTIO_VGA) += hw/display/virtio-vga.c
> check-qtest-pci-y += tests/intel-hda-test$(EXESUF)
> gcov-files-pci-y += hw/audio/intel-hda.c hw/audio/hda-codec.c
> +check-qtest-pci-$(CONFIG_IVSHMEM) += tests/ivshmem-test$(EXESUF)
> +gcov-files-pci-y += hw/misc/ivshmem.c
Based on my comment from Saturday, this line is probably wrong... but
doesn't need to hold up this queue.
My patch adding it to i386 variable had used i386-softmmu/hw/... path.
We then have this for x86_64:
gcov-files-x86_64-y = $(subst
i386-softmmu/,x86_64-softmmu/,$(gcov-files-i386-y))
gcov-files-pci-y is currently only added to i386, so the prefix could
just be added back, whereas when we do pci tests also for ppc, arm, etc.
we'll have to copy that subst around or think of a better solution.
Marc-André, can you prepare a follow-up fix for ivshmem-test please?
Regards,
Andreas
>
> check-qtest-i386-y = tests/endianness-test$(EXESUF)
> check-qtest-i386-y += tests/fdc-test$(EXESUF)
[snip]
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
- [Qemu-devel] [PULL v2 47/50] ivshmem: rename MSI eventfd_table, (continued)
- [Qemu-devel] [PULL v2 47/50] ivshmem: rename MSI eventfd_table, marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 48/50] ivshmem: use kvm irqfd for msi notifications, marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 49/50] ivshmem: use little-endian int64_t for the protocol, marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 50/50] doc: document ivshmem & hugepages, marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 39/50] msix: implement pba write (but read-only), marcandre . lureau, 2015/10/12
- Re: [Qemu-devel] [PULL v2 00/50] Ivshmem patches, Peter Maydell, 2015/10/13
- [Qemu-devel] [PULL v2 01/50] tests: Add ivshmem qtest, marcandre . lureau, 2015/10/15
- Re: [Qemu-devel] [PULL v2 01/50] tests: Add ivshmem qtest,
Andreas Färber <=
- [Qemu-devel] [PULL v2 15/50] ivshmem: remove useless ivshmem_update_irq() val argument, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 07/50] ivshmem: remove unnecessary dup(), marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 24/50] ivshmem: migrate with VMStateDescription, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 25/50] ivshmem: shmfd can be 0, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 19/50] ivshmem: improve error handling, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 27/50] ivshmem: add device description, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 30/50] ivshmem: error on too many eventfd received, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 35/50] ivshmem-server: fix hugetlbfs support, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 36/50] docs: update ivshmem device spec, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 46/50] ivshmem: remove EventfdEntry.vector, marcandre . lureau, 2015/10/15