[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v3 39/51] contrib: remove unnecessary strdup()
From: |
marcandre . lureau |
Subject: |
[Qemu-devel] [PULL v3 39/51] contrib: remove unnecessary strdup() |
Date: |
Tue, 13 Oct 2015 16:26:06 +0200 |
From: Marc-André Lureau <address@hidden>
getopt() optarg points to argv memory, no need to dup those values,
fixes small leaks detected by clang-analyzer.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
contrib/ivshmem-client/main.c | 2 +-
contrib/ivshmem-server/main.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/contrib/ivshmem-client/main.c b/contrib/ivshmem-client/main.c
index 44531f5..28dd81e 100644
--- a/contrib/ivshmem-client/main.c
+++ b/contrib/ivshmem-client/main.c
@@ -53,7 +53,7 @@ ivshmem_client_parse_args(IvshmemClientArgs *args, int argc,
char *argv[])
break;
case 'S': /* unix_sock_path */
- args->unix_sock_path = strdup(optarg);
+ args->unix_sock_path = optarg;
break;
default:
diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c
index b960048..54ff001 100644
--- a/contrib/ivshmem-server/main.c
+++ b/contrib/ivshmem-server/main.c
@@ -92,15 +92,15 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int
argc, char *argv[])
break;
case 'p': /* pid_file */
- args->pid_file = strdup(optarg);
+ args->pid_file = optarg;
break;
case 'S': /* unix_socket_path */
- args->unix_socket_path = strdup(optarg);
+ args->unix_socket_path = optarg;
break;
case 'm': /* shm_path */
- args->shm_path = strdup(optarg);
+ args->shm_path = optarg;
break;
case 'l': /* shm_size */
--
2.4.3
- [Qemu-devel] [PULL v3 50/51] ivshmem: use little-endian int64_t for the protocol, (continued)
- [Qemu-devel] [PULL v3 50/51] ivshmem: use little-endian int64_t for the protocol, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 47/51] ivshmem: remove EventfdEntry.vector, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 51/51] doc: document ivshmem & hugepages, marcandre . lureau, 2015/10/13
- [Qemu-devel] [PULL v3 12/51] ivshmem: limit maximum number of peers to G_MAXUINT16, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v3 14/51] ivshmem: allocate eventfds in resize_peers(), marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v3 27/51] ivshmem: add device description, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v3 13/51] ivshmem: simplify around increase_dynamic_storage(), marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v3 16/51] ivshmem: initialize max_peer to -1, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v3 32/51] util: const event_notifier_get_fd() argument, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v3 40/51] msix: implement pba write (but read-only), marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v3 39/51] contrib: remove unnecessary strdup(),
marcandre . lureau <=
- [Qemu-devel] [PULL v3 38/51] ivshmem: add check on protocol version in QEMU, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v3 41/51] qtest: add qtest_add_abrt_handler(), marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v3 46/51] ivshmem: add hostmem backend, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v3 45/51] ivshmem: use qemu_strtosz(), marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v3 49/51] ivshmem: use kvm irqfd for msi notifications, marcandre . lureau, 2015/10/15
- Re: [Qemu-devel] [PULL v3 00/51] Ivshmem patches, Peter Maydell, 2015/10/15