qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv12/8] trace: Add 'vcpu' event property


From: Lluís Vilanova
Subject: Re: [Qemu-devel] [PATCHv12/8] trace: Add 'vcpu' event property
Date: Fri, 16 Oct 2015 17:45:28 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Stefan Hajnoczi writes:

> On Tue, Oct 13, 2015 at 07:10:33PM +0200, Lluís Vilanova wrote:
>> diff --git a/scripts/tracetool/format/h.py b/scripts/tracetool/format/h.py
>> index 9b39430..4bdb48f 100644
>> --- a/scripts/tracetool/format/h.py
>> +++ b/scripts/tracetool/format/h.py
>> @@ -6,7 +6,7 @@ trace/generated-tracers.h
>> """
>> 
>> __author__     = "Lluís Vilanova <address@hidden>"
>> -__copyright__ = "Copyright 2012-2014, Lluís Vilanova <address@hidden>"
>> +__copyright__  = "Copyright 2012-2015, Lluís Vilanova <address@hidden>"
>> __license__    = "GPL version 2 or (at your option) any later version"
>> 
>> __maintainer__ = "Stefan Hajnoczi"
>> @@ -23,6 +23,8 @@ def generate(events, backend):
>> '#define TRACE__GENERATED_TRACERS_H',
>> '',
>> '#include "qemu-common.h"',
>> +        '',
>> +        'typedef struct CPUState CPUState;',

> Here...

>> diff --git a/scripts/tracetool/format/ust_events_c.py 
>> b/scripts/tracetool/format/ust_events_c.py
>> index bc97093..92064f0 100644
>> --- a/scripts/tracetool/format/ust_events_c.py
>> +++ b/scripts/tracetool/format/ust_events_c.py
>> @@ -6,7 +6,7 @@ trace/generated-ust.c
>> """
>> 
>> __author__     = "Mohamad Gebai <address@hidden>"
>> -__copyright__  = "Copyright 2012, Mohamad Gebai <address@hidden>"
>> +__copyright__  = "Copyright 2012, 2015, Mohamad Gebai <address@hidden>"
>> __license__    = "GPL version 2 or (at your option) any later version"
>> 
>> __maintainer__ = "Stefan Hajnoczi"
>> @@ -30,4 +30,6 @@ def generate(events, backend):
>> ' */',
>> '#pragma GCC diagnostic ignored "-Wredundant-decls"',
>> '',
>> +        'typedef struct CPUState CPUState;',
>> +        '',
>> '#include "generated-ust-provider.h"')

> ...and here is okay but please generate a comment so it's clear why this
> needs to be defined.

Will do.

Thanks,
  Lluis

-- 
"And it's much the same thing with knowledge, for whenever you learn
something new, the whole world becomes that much richer."
-- The Princess of Pure Reason, as told by Norton Juster in The Phantom
Tollbooth



reply via email to

[Prev in Thread] Current Thread [Next in Thread]