qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL v2 00/12] qemu-ga patch queue


From: Peter Maydell
Subject: Re: [Qemu-devel] [PULL v2 00/12] qemu-ga patch queue
Date: Fri, 16 Oct 2015 19:05:28 +0100

On 15 October 2015 at 17:05, Michael Roth <address@hidden> wrote:
> Hi Peter,
>
> Please note that 'glib-compat: add 2.38/2.40/2.46 asserts' is also in
> Marc-André's recent ivshmem PULL. The 2 versions of the patches are identical,
> but let me know if you'd prefer a re-send/re-base later.
>
> The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10:
>
>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-10-12' 
> into staging (2015-10-13 10:42:06 +0100)
>
> are available in the git repository at:
>
>
>   git://github.com/mdroth/qemu.git tags/qga-pull-2015-10-14-v2-tag
>
> for you to fetch changes up to 32bcf9327f9ad614712999f514707415a53ec620:
>
>   qga: guest-exec simple stdin/stdout/stderr redirection (2015-10-14 22:39:09 
> -0500)
>
> ----------------------------------------------------------------
> qemu-ga patch queue
>
> * add unit tests for qemu-ga
> * add guest-exec support for posix/w32 guests
> * added 'qemu-ga' target for w32. this allows us to do full MSI build,
>   without overloading 'qemu-ga.exe' target with uneeded dependencies.
> * number of s/g_new/g_malloc/ conversions for qga
>
> v2:
> * commit message and qapi documentation spelling fixes
> * rename 'inp-data' guest-exec param to 'input-data'
>

Hi; I'm afraid this fails my build tests.

Compile failures on OSX:
/Users/pm215/src/qemu-for-merges/tests/test-qga.c:366:51: warning:
format specifies type 'long' but the argument has type 'int64_t' (aka
'long long') [-Wformat]
                          " 'buf-b64': '%s' } }", id, enc);
                                                  ^~
/Users/pm215/src/qemu-for-merges/tests/test-qga.c:382:27: warning:
format specifies type 'long' but the argument has type 'int64_t' (aka
'long long') [-Wformat]
                          id);
                          ^~
/Users/pm215/src/qemu-for-merges/tests/test-qga.c:390:27: warning:
format specifies type 'long' but the argument has type 'int64_t' (aka
'long long') [-Wformat]
                          id);
                          ^~
/Users/pm215/src/qemu-for-merges/tests/test-qga.c:416:27: warning:
format specifies type 'long' but the argument has type 'int64_t' (aka
'long long') [-Wformat]
                          id);
                          ^~
/Users/pm215/src/qemu-for-merges/tests/test-qga.c:433:27: warning:
format specifies type 'long' but the argument has type 'int64_t' (aka
'long long') [-Wformat]
                          id);
                          ^~
/Users/pm215/src/qemu-for-merges/tests/test-qga.c:449:27: warning:
format specifies type 'long' but the argument has type 'int64_t' (aka
'long long') [-Wformat]
                          id, 6, SEEK_SET);
                          ^~
/Users/pm215/src/qemu-for-merges/tests/test-qga.c:463:27: warning:
format specifies type 'long' but the argument has type 'int64_t' (aka
'long long') [-Wformat]
                          id);
                          ^~
/Users/pm215/src/qemu-for-merges/tests/test-qga.c:482:27: warning:
format specifies type 'long' but the argument has type 'int64_t' (aka
'long long') [-Wformat]
                          id);
                          ^~
/Users/pm215/src/qemu-for-merges/tests/test-qga.c:537:27: warning:
format specifies type 'long' but the argument has type 'long long'
[-Wformat]
                          current + time * 1000);
                          ^~~~~~~~~~~~~~~~~~~~~
/Users/pm215/src/qemu-for-merges/tests/test-qga.c:632:35: error: use
of undeclared identifier 'G_SPAWN_DEFAULT'
    g_spawn_sync(NULL, argv, env, G_SPAWN_DEFAULT,
                                  ^
9 warnings and 1 error generated.

Most of these look like trying to use G_GINT64_FORMAT
for int64_t rather than PRId64.

The last one is using a value that wasn't implemented until
after our current minimum glib version (I think it came in
in 2.37, though the glib docs fail to mention this). Needs
to use "0" instead.

Win32 also fails to build:

/home/petmay01/linaro/qemu-for-merges/qga/commands.c: In function
‘qmp_guest_exec_status’:
/home/petmay01/linaro/qemu-for-merges/qga/commands.c:138: warning:
cast to pointer from integer of different size
/home/petmay01/linaro/qemu-for-merges/qga/commands.c: In function
‘qmp_guest_exec’:
/home/petmay01/linaro/qemu-for-merges/qga/commands.c:407: warning:
cast from pointer to integer of different size

which I think is because GPid is a pointer type on Windows
and the code is assuming it's an integer.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]