[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via c
From: |
Kevin O'Connor |
Subject: |
Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline. |
Date: |
Mon, 19 Oct 2015 07:52:34 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Oct 19, 2015 at 12:12:34PM +0100, Peter Maydell wrote:
> On 19 October 2015 at 10:17, Gerd Hoffmann <address@hidden> wrote:
> > ----------------------------------------------------------------
> > fw_cfg: add dma interface, add strings via cmdline.
> >
> > ----------------------------------------------------------------
>
> Hi. I'm afraid this fails 'make check':
>
> TEST: tests/fw_cfg-test... (pid=17533)
> /i386/fw_cfg/signature: OK
> /i386/fw_cfg/id: **
> ERROR:/home/petmay01/qemu/tests/fw_cfg-test.c:40:test_fw_cfg_id:
> assertion failed (qfw_cfg_get_u32(fw_cfg, FW_CFG_ID) == 1): (3 == 1)
> FAIL
>
> (same failure on 64-bit ARM, ppc64be, OSX, 32-bit ARM).
>
> Windows fails to compile:
> /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c: In function
> ‘fw_cfg_dma_mem_read’:
> /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c:406: warning:
> integer constant is too large for ‘long’ type
I don't have a Windows test environment, but I suspect the following:
#define FW_CFG_DMA_SIGNATURE 0x51454d5520434647 /* "QEMU CFG" */
should be changed to:
#define FW_CFG_DMA_SIGNATURE 0x51454d5520434647ULL /* "QEMU CFG" */
If that sounds right, I'll respin the last patch.
-Kevin
- [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline., Gerd Hoffmann, 2015/10/19
- [Qemu-devel] [PULL 6/7] Enable fw_cfg DMA interface for x86, Gerd Hoffmann, 2015/10/19
- [Qemu-devel] [PULL 5/7] Enable fw_cfg DMA interface for ARM, Gerd Hoffmann, 2015/10/19
- [Qemu-devel] [PULL 3/7] fw_cfg DMA interface documentation, Gerd Hoffmann, 2015/10/19
- [Qemu-devel] [PULL 1/7] fw_cfg: insert string blobs via qemu cmdline, Gerd Hoffmann, 2015/10/19
- [Qemu-devel] [PULL 4/7] Implement fw_cfg DMA interface, Gerd Hoffmann, 2015/10/19
- [Qemu-devel] [PULL 7/7] fw_cfg: Define a static signature to be returned on DMA port reads, Gerd Hoffmann, 2015/10/19
- [Qemu-devel] [PULL 2/7] fw_cfg: document fw_cfg_modify_iXX() update functions, Gerd Hoffmann, 2015/10/19
- Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline., Peter Maydell, 2015/10/19
- Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline.,
Kevin O'Connor <=
- Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline., Peter Maydell, 2015/10/19
- Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline., Kevin O'Connor, 2015/10/19
- Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline., Marc Marí, 2015/10/19
- Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline., Gerd Hoffmann, 2015/10/19
- Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline., Gerd Hoffmann, 2015/10/19
- Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline., Peter Maydell, 2015/10/19
Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline., Laszlo Ersek, 2015/10/19