[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] block/gluster: rename [server, volname, ima
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] block/gluster: rename [server, volname, image] -> [host, volume, path] |
Date: |
Mon, 19 Oct 2015 14:10:22 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/19/2015 06:13 AM, Prasanna Kumar Kalever wrote:
> for example in 'servers' tuple values we use 'server' variable for key 'host'
> in the code, it will be quite messy to have colliding names for variables,
> so to maintain better readability and makes it consistent with other existing
> code as well as the input keys/options, this patch renames the following
> variables
> 'server' -> 'host'
> 'image' -> 'path'
> 'volname' -> 'volume'
>
> Signed-off-by: Prasanna Kumar Kalever <address@hidden>
> ---
> block/gluster.c | 54 +++++++++++++++++++++++++++---------------------------
> 1 file changed, 27 insertions(+), 27 deletions(-)
>
As mentioned on 1/3, I suspect you want to reorder your series to put
this one first.
Seems fairly mechanical.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 1/3] block/gluster: add support for multiple gluster servers, Prasanna Kumar Kalever, 2015/10/19
- [Qemu-devel] [PATCH 2/3] block/gluster: rename [server, volname, image] -> [host, volume, path], Prasanna Kumar Kalever, 2015/10/19
- Re: [Qemu-devel] [PATCH 2/3] block/gluster: rename [server, volname, image] -> [host, volume, path],
Eric Blake <=
- [Qemu-devel] [PATCH 3/3] block/gluster: code cleanup, Prasanna Kumar Kalever, 2015/10/19
- Re: [Qemu-devel] [PATCH 1/3] block/gluster: add support for multiple gluster servers, Eric Blake, 2015/10/19