qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used b


From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI
Date: Tue, 20 Oct 2015 00:20:18 +0300

On Tue, Oct 20, 2015 at 01:54:12AM +0800, Xiao Guangrong wrote:
> 
> 
> On 10/19/2015 06:25 PM, Michael S. Tsirkin wrote:
> >On Mon, Oct 19, 2015 at 11:18:36AM +0200, Igor Mammedov wrote:
> >>On Mon, 19 Oct 2015 09:56:12 +0300
> >>"Michael S. Tsirkin" <address@hidden> wrote:
> >>
> >>>On Sun, Oct 11, 2015 at 11:52:54AM +0800, Xiao Guangrong wrote:
> >>[...]
> >>>>diff --git a/include/hw/mem/nvdimm.h b/include/hw/mem/nvdimm.h
> >>>>index f6bd2c4..aa95961 100644
> >>>>--- a/include/hw/mem/nvdimm.h
> >>>>+++ b/include/hw/mem/nvdimm.h
> >>>>@@ -15,6 +15,10 @@
> >>>>
> >>>>  #include "hw/mem/dimm.h"
> >>>>
> >>>>+/* Memory region 0xFF00000 ~ 0xFFF00000 is reserved for NVDIMM
> >>>>ACPI. */ +#define NVDIMM_ACPI_MEM_BASE   0xFF000000ULL
> >>Michael,
> >>
> >>If it's ok to map control RAM region directly from QEMU at arbitrary
> >>location
> >
> >It's a fair question. Where is it reserved? In which spec?
> >
> 
> The region 0xFF00000 ~ 0xFFF00000 is just reserved for vDSM implementation,
> it is not required by spec.

See Igor's comment then. You can't just steal it like that.

-- 
MST



reply via email to

[Prev in Thread] Current Thread [Next in Thread]