Re: [Qemu-devel] [PULL 0/9] Next set of s390x patches

[Christian Borntraeger]

Am 20.10.2015 um 17:35 schrieb Peter Maydell:
> On 20 October 2015 at 16:00, Cornelia Huck <address@hidden> wrote:
>> The following changes since commit ee9dfed242610ecb91418270fd46b875ed56e201:
>>
>>   Merge remote-tracking branch 'remotes/kraxel/tags/pull-input-20151020-1' 
>> into staging (2015-10-20 12:56:45 +0100)
>>
>> are available in the git repository at:
>>
>>   git://github.com/cohuck/qemu tags/s390x-20151020
>>
>> for you to fetch changes up to bde5d1bcb63973802c21183d730e0ea7c0ae227c:
>>
>>   s390x/cmma: clean up cmma reset (2015-10-20 16:21:01 +0200)
>>
>> ----------------------------------------------------------------
>> More s390x patches. The first ones are fixes: A regression, missed
>> compat and a missed part of the SIMD support. The others contain
>> optimizations and cleanup.
>>
>> ----------------------------------------------------------------
> 
> Hi; I'm afraid this fails to build with clang:
> /home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-virtio-ccw.c:38:12:
> error: duplicate 'const' declaration specifier
> [-Werror,-Wduplicate-decl-specifier]
> const char const *reset_dev_types[] = {
>            ^
> 
> 
> 
> Did you mean "const char * const" ? (I always have trouble with this
> corner of C syntax...)

"const char * const" looks right, as the pointer and the data is const.
When fixing, you might also add "static" (please double check)

Christian