Re: [Qemu-devel] [PATCH v8 35/54] Postcopy: Postcopy startup in migration thread

[Juan Quintela]

"Dr. David Alan Gilbert (git)" <address@hidden> wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Rework the migration thread to setup and start postcopy.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> Reviewed-by: Amit Shah <address@hidden>


> diff --git a/include/migration/migration.h b/include/migration/migration.h
> index aecf284..0586f8c 100644
> --- a/include/migration/migration.h
> +++ b/include/migration/migration.h
> @@ -136,6 +136,9 @@ struct MigrationState
>      /* Flag set once the migration has been asked to enter postcopy */
>      bool start_postcopy;
>  
> +    /* Flag set once the migration thread is running (and needs joining) */
> +    bool migration_thread_started;
> +
>      /* bitmap of pages that have been sent at least once
>       * only maintained and used in postcopy at the moment
>       * where it's used to send the dirtymap at the start

if you split it, we can already integrate the migration_thread_started.

I would suggest to change the name to migration_thread_running, but you
are the native one here O:-)

If you don't want to add this variable, I *think* we could use
MIGRATION_STATE_NONE with just some little rearangements of the code.
On the other hand, it could be racy :-(


Reviewed-by: Juan Quintela <address@hidden>


Split only or rename variable just if you consider it convenient.