Re: [Qemu-devel] [PATCH RFC V5 1/9] hw/intc: Implement GIC-500 support files

[Shlomo Pongratz]

See inline

On Wednesday, October 21, 2015, Pavel Fedin <address@hidden> wrote:
>  Hello!
>
> >> See this: http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg02349.html. This is also a part of my live migration RFC.
> >> I remember that Peter told long time ago that "it should really be a property", when i integrated full affinity support. But, he currently
> >> refused to accept this small standalone patch because there are no users for now. My GICv3 live migration is waiting for kernel API to be
> >> ready. And kernel API is waiting for kernel 4.5 development cycle to begin.
> > So please resubmit it and mention me as a client.
>
>  Ok, i'll PING, but you can also include it into your patchset. BTW, why is it still RFC?

It is still in RFC because there are still many comments as you can see :-)

> > But I wonder if accessing the property in real time (not in only in initialization) from the GIC code will have impact on performance.
>
>  It can, but you can cache them during realize. For example, if you accept my data layout, then you can just add "uint64_t mp_affinity" to GICv3CPUState.

Do you mean that in virt.c::create_gic I'll take the cpu's affinity from the cpu's property and not directly from ARM_CPU(qemu_get_cpu(i))->mp_affinity

I can do that but that depends on acceptance of your patch.

 

> Kind regards,
> Pavel Fedin
> Expert Engineer
> Samsung Electronics Research center Russia