[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH v5 04/12] aio: introduce aio_{disab
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH v5 04/12] aio: introduce aio_{disable, enable}_external |
Date: |
Wed, 21 Oct 2015 22:20:03 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Oct 22, 2015 at 10:11:16AM +0800, Fam Zheng wrote:
> On Wed, 10/21 11:56, Jeff Cody wrote:
> > > +static inline bool aio_node_check(AioContext *ctx, bool is_external)
> > > +{
> > > + return !is_external || !atomic_read(&ctx->external_disable_cnt);
> > > +}
> > > +
> >
> > It seems a little odd to me to have this helper function take the
> > is_external bool field from the node as the argument - any reason to
> > do that, rather than pass in the AioHandler and have aio_node_check()
> > parse whatever fields it deems necessary from it?
>
> AioHandler is defined differently for posix and win32, but I didn't want to
> duplicate this function in two files.
>
> Fam
That makes sense, thanks.
- [Qemu-devel] [PATCH v5 00/12] block: Protect nested event loop with bdrv_drained_begin and bdrv_drained_end, Fam Zheng, 2015/10/20
- [Qemu-devel] [PATCH v5 05/12] block: Introduce "drained begin/end" API, Fam Zheng, 2015/10/20
- [Qemu-devel] [PATCH v5 06/12] block: Add "drained begin/end" for transactional external snapshot, Fam Zheng, 2015/10/20
- [Qemu-devel] [PATCH v5 07/12] block: Add "drained begin/end" for transactional backup, Fam Zheng, 2015/10/20
- [Qemu-devel] [PATCH v5 08/12] block: Add "drained begin/end" for transactional blockdev-backup, Fam Zheng, 2015/10/20
- [Qemu-devel] [PATCH v5 09/12] block: Add "drained begin/end" for internal snapshot, Fam Zheng, 2015/10/20