Re: [Qemu-devel] [Qemu-block] [PATCH v5 04/12] aio: introduce aio_{disable, enable}_external

[Fam Zheng]

On Wed, 10/21 11:56, Jeff Cody wrote:
> > +static inline bool aio_node_check(AioContext *ctx, bool is_external)
> > +{
> > +    return !is_external || !atomic_read(&ctx->external_disable_cnt);
> > +}
> > +
> 
> It seems a little odd to me to have this helper function take the
> is_external bool field from the node as the argument - any reason to
> do that, rather than pass in the AioHandler and have aio_node_check()
> parse whatever fields it deems necessary from it?

AioHandler is defined differently for posix and win32, but I didn't want to
duplicate this function in two files.

Fam