[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 3/3] block/gluster: add support for multiple
From: |
Peter Krempa |
Subject: |
Re: [Qemu-devel] [PATCH v9 3/3] block/gluster: add support for multiple gluster servers |
Date: |
Thu, 22 Oct 2015 09:03:07 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Oct 21, 2015 at 19:04:11 +0530, Prasanna Kumar Kalever wrote:
...
> ---
> block/gluster.c | 420
> +++++++++++++++++++++++++++++++++++++++++++++------
> qapi/block-core.json | 62 +++++++-
> 2 files changed, 433 insertions(+), 49 deletions(-)
>
> diff --git a/block/gluster.c b/block/gluster.c
> index ededda2..62b6656 100644
> --- a/block/gluster.c
> +++ b/block/gluster.c
...
> +
>
> static void qemu_gluster_gconf_free(GlusterConf *gconf)
> {
> if (gconf) {
> - g_free(gconf->host);
> g_free(gconf->volume);
> g_free(gconf->path);
> - g_free(gconf->transport);
> + if (gconf->gsconf) {
> + g_free(gconf->gsconf[0].host);
> + g_free(gconf->gsconf[0].transport);
> + g_free(gconf->gsconf);
Looks like this leaks second and any further server config struct.
> + }
> g_free(gconf);
> }
> }
Peter
signature.asc
Description: Digital signature
- [Qemu-devel] [PATCH v2 1/3] block/gluster: rename [server, volname, image] -> [host, volume, path], Prasanna Kumar Kalever, 2015/10/21
- [Qemu-devel] [PATCH v2 2/3] block/gluster: code cleanup, Prasanna Kumar Kalever, 2015/10/21
- Re: [Qemu-devel] [PATCH v2 1/3] block/gluster: rename [server, volname, image] -> [host, volume, path], Eric Blake, 2015/10/21
- [Qemu-devel] [PATCH v9 3/3] block/gluster: add support for multiple gluster servers, Prasanna Kumar Kalever, 2015/10/22
- Re: [Qemu-devel] [PATCH v9 3/3] block/gluster: add support for multiple gluster servers,
Peter Krempa <=