Re: [Qemu-devel] [PATCH v9 05/17] qapi: Unbox base members

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 10/21/2015 07:34 AM, Markus Armbruster wrote:
>
>> 
>> The least verbose naming convention for a conversion function I can
>> think of right now is TBase(), where T is the name of a type with a
>> base.  Compare:
>> 
>>     foo((Parent *)child, blah)
>>     foo(ChildBase(child), blah)
>> 
>> Tolerable?  Worthwhile?
>
> 'TBase' won't work. We already have BlockdevOptionsBase as a subtype of
> BlockdevOptions, and using 'TBase' would give us
> 'BlockdevOptionsBase(options)' which is now ambiguous between the type
> name and intended function call.  I'll probably go with
> qapi_TYPE_base(), and see how long that looks.

I'd have no problem with renaming things that don't impact wire ABI.
A quick grep suggests churn would be minimal.