Re: [Qemu-devel] [PATCH v7 34/39] block: Inquire tray state before tray-moved events

[Kevin Wolf]

Am 19.10.2015 um 17:53 hat Max Reitz geschrieben:
> blk_dev_change_media_cb() is called for all potential tray movements;
> however, it is possible to request closing the tray but nothing actually
> happening (on a floppy disk drive without a medium).
> 
> Thus, the actual tray status should be inquired before sending a
> tray-moved event (and an event should be sent whenever the status
> changed).
> 
> Checking @load is now superfluous; it was necessary because it was
> possible to change a medium without having explicitly opened the tray
> and closed it again (or it might have been possible, at least). This is
> no longer possible, though.
> 
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>

Reviewed-by: Kevin Wolf <address@hidden>