Re: [Qemu-devel] [PATCH v10 01/25] tests/qapi-schema: Test for reserved names, empty struct

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 10/23/2015 06:33 AM, Markus Armbruster wrote:
>> Eric Blake <address@hidden> writes:
[...]
>>> +++ b/tests/qapi-schema/struct-name-list.json
>>> @@ -0,0 +1,5 @@
>>> +# Potential C name collision
>>> +# FIXME - This parses and compiles on its own, but prevents the user from
>>> +# creating a type named 'Foo' and using ['Foo'] for an array.  We should
>>> +# reject the use of any non-array type names ending in 'List'.
>>> +{ 'struct': 'FooList', 'data': { 's': 'str' } }
>> 
>> "Non-array type name" makes no sense when talking about the QAPI schema,
>> because arrays don't have names there.
>
> Suggestions? Maybe s/non-array//? The wording changes in 2/25 when the
> test starts working.

Dropping non-array works for me.