[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v8 3/5] block: support passing 'backing': '' to 'blo
From: |
Alberto Garcia |
Subject: |
[Qemu-devel] [PATCH v8 3/5] block: support passing 'backing': '' to 'blockdev-add' |
Date: |
Mon, 26 Oct 2015 14:27:15 +0200 |
Passing an empty string allows opening an image but not its backing
file. This was already described in the API documentation, only the
implementation was missing.
This is useful for creating snapshots using images opened with
blockdev-add, since they are not supposed to have a backing image
before the operation.
Signed-off-by: Alberto Garcia <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
---
block.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/block.c b/block.c
index e9f40dc..132719d 100644
--- a/block.c
+++ b/block.c
@@ -1394,6 +1394,7 @@ static int bdrv_open_inherit(BlockDriverState **pbs,
const char *filename,
BlockDriverState *bs;
BlockDriver *drv = NULL;
const char *drvname;
+ const char *backing;
Error *local_err = NULL;
int snapshot_flags = 0;
@@ -1461,6 +1462,12 @@ static int bdrv_open_inherit(BlockDriverState **pbs,
const char *filename,
assert(drvname || !(flags & BDRV_O_PROTOCOL));
+ backing = qdict_get_try_str(options, "backing");
+ if (backing && *backing == '\0') {
+ flags |= BDRV_O_NO_BACKING;
+ qdict_del(options, "backing");
+ }
+
bs->open_flags = flags;
bs->options = options;
options = qdict_clone_shallow(options);
--
2.6.1
- [Qemu-devel] [PATCH v8 0/5] Add 'blockdev-snapshot' command, Alberto Garcia, 2015/10/26
- [Qemu-devel] [PATCH v8 1/5] block: check for existing device IDs in external_snapshot_prepare(), Alberto Garcia, 2015/10/26
- [Qemu-devel] [PATCH v8 5/5] block: add tests for the 'blockdev-snapshot' command, Alberto Garcia, 2015/10/26
- [Qemu-devel] [PATCH v8 2/5] block: rename BlockdevSnapshot to BlockdevSnapshotSync, Alberto Garcia, 2015/10/26
- [Qemu-devel] [PATCH v8 4/5] block: add a 'blockdev-snapshot' QMP command, Alberto Garcia, 2015/10/26
- [Qemu-devel] [PATCH v8 3/5] block: support passing 'backing': '' to 'blockdev-add',
Alberto Garcia <=
- Re: [Qemu-devel] [PATCH v8 0/5] Add 'blockdev-snapshot' command, Kevin Wolf, 2015/10/27