Re: [Qemu-devel] [PATCH 11/11] log: add "-d trace:PATTERN"

[Eric Blake]

On 10/26/2015 07:12 AM, Lluís Vilanova wrote:
> Denis V Lunev writes:
> 
>> From:  Paolo Bonzini <address@hidden>
>> This is a bit easier to use than "-trace" if you are also enabling
>> other kinds of logging.  It is also more discoverable for experienced
>> QEMU users, and accessible from user-mode emulators.
> 
> I'm not sure this should be added, since the same functionality is also
> available through "-trace enable=<pattern>" (and the shortcut "-trace
> <pattern>").

Having more than one way to do something is not necessarily bad; it does
imply more maintenance to keep both ways working, but if one way is more
discoverable than the other it may be worth it.

> 
> Also, I'd rather fold event name discovery into "-trace enable=?" (and the
> shortcut "-trace ?"), mimicking the format already available for CPUs ("-cpu
> ?").
> 

If we do that, we should also support '-trace enable=help', because ? is
a shell metacharacter, and we have been moving towards using 'help'
rather than '?' to minimize the need for shell quoting when asking for help.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature