Re: [Qemu-devel] [PATCH 04/11] trace: no need to call trace_backend_init in different branches now

[Paolo Bonzini]

On 26/10/2015 10:10, Denis V. Lunev wrote:
> original idea to split calling locations was to trace tracing thread
> in the final child process according to
> 
>     commit 8a745f2a9296ad2cf6bda33534ed298f2625a4ad
>     Author: Michael Mueller
>     Date:   Mon Sep 23 16:36:54 2013 +0200
> 
> os_daemonize is now on top of both locations. Drop unneeded ifs.

Oh, that's nice! :-)

Reviewed-by: Paolo Bonzini <address@hidden>

Paolo

> Signed-off-by: Denis V. Lunev <address@hidden>
> ---
>  vl.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/vl.c b/vl.c
> index b1ddd3f..7ce9d70 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4083,10 +4083,8 @@ int main(int argc, char **argv, char **envp)
>          qemu_set_log(mask);
>      }
>  
> -    if (!is_daemonized()) {
> -        if (!trace_init_backends()) {
> -            exit(1);
> -        }
> +    if (!trace_init_backends()) {
> +        exit(1);
>      }
>  
>      /* If no data_dir is specified then try to find it relative to the
> @@ -4635,12 +4633,6 @@ int main(int argc, char **argv, char **envp)
>  
>      os_setup_post();
>  
> -    if (is_daemonized()) {
> -        if (!trace_init_backends()) {
> -            exit(1);
> -        }
> -    }
> -
>      main_loop();
>      bdrv_close_all();
>      pause_all_vcpus();
>