[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 09/25] qapi: Prefer typesafe upcasts to qapi
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v10 09/25] qapi: Prefer typesafe upcasts to qapi base classes |
Date: |
Mon, 26 Oct 2015 14:53:20 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/26/2015 11:54 AM, Markus Armbruster wrote:
>> It sounds like I have two options for v11:
>>
>> 1. Keep 9/25 introducing gen_upcast(), just for union types, and
>> including testsuite coverage. In 10/25, make use of the upcast functions
>> to struct as part of making structs sane.
>>
>> 2. Swap the patch order: do 10/25 to alter struct layout first, using
>> ugly casts; then implement 9/25 that adds gen_upcast() and fixes the
>> ugly casts to instead use the new upcast functions.
>>
>> I can go either way, so do you have any preference?
>
> I think I'd 3. Do 10/25 first, with gen_upcast() squashed in, and used
> for casts to base. That gen_upcast() will just work for unions, too.
> Least churn.
I actually started with option 3 back when first writing v10, then
decided that it made the patch big enough, and the addition was
orthogonal enough, to go with the split patches at the time I actually
posted v10.
>
> But any of the three options should work.
Good. Because I had already gone with option 1 locally before asking
the question, which means now I don't have to respin to get option 2 or 3 :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v10 25/25] qapi: Simplify gen_struct_field(), (continued)
- [Qemu-devel] [PATCH v10 25/25] qapi: Simplify gen_struct_field(), Eric Blake, 2015/10/23
- [Qemu-devel] [PATCH v10 12/25] qapi: Start converting to new qapi union layout, Eric Blake, 2015/10/23
- [Qemu-devel] [PATCH v10 15/25] block: Convert to new qapi union layout, Eric Blake, 2015/10/23
- [Qemu-devel] [PATCH v10 14/25] tests: Convert to new qapi union layout, Eric Blake, 2015/10/23
- [Qemu-devel] [PATCH v10 09/25] qapi: Prefer typesafe upcasts to qapi base classes, Eric Blake, 2015/10/23
[Qemu-devel] [PATCH v10 20/25] memory: Convert to new qapi union layout, Eric Blake, 2015/10/23
[Qemu-devel] [PATCH v10 22/25] qapi: Finish converting to new qapi union layout, Eric Blake, 2015/10/23
[Qemu-devel] [PATCH v10 18/25] char: Convert to new qapi union layout, Eric Blake, 2015/10/23
[Qemu-devel] [PATCH v10 23/25] qapi: Reserve 'u' member name, Eric Blake, 2015/10/23
[Qemu-devel] [PATCH v10 11/25] qapi-visit: Remove redundant functions for flat union base, Eric Blake, 2015/10/23
[Qemu-devel] [PATCH v10 16/25] sockets: Convert to new qapi union layout, Eric Blake, 2015/10/23
[Qemu-devel] [PATCH v10 19/25] input: Convert to new qapi union layout, Eric Blake, 2015/10/23