[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] backends/hostmem-file: Add file-name property
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] backends/hostmem-file: Add file-name property |
Date: |
Tue, 27 Oct 2015 08:37:52 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/27/2015 07:53 AM, Pavel Fedin wrote:
> This option allows to explicitly specify file name to use with the backend.
> This is important when using it together with ivshmem in order to make it
> backed by hugetlbfs. By default filename is autogenerated using mkstemp(),
> and the file is unlink()ed after creation, effectively making it
> anonymous. This is not very useful with ivshmem because it ends up in a
> memory which cannot be accessed by something else.
>
> Signed-off-by: Pavel Fedin <address@hidden>
> Tested-by: Igor Skalkin <address@hidden>
> ---
> backends/hostmem-file.c | 26 +++++++++++++++++++++++++-
> exec.c | 36 ++++++++++++++++++++++++------------
> include/exec/memory.h | 3 +++
> include/exec/ram_addr.h | 2 +-
> memory.c | 4 +++-
> numa.c | 2 +-
> qemu-doc.texi | 2 +-
> 7 files changed, 58 insertions(+), 17 deletions(-)
Is there a missing qapi change, so that the new filename attribute can
also be specified by QMP command? Or do we not support hotplug of
ivshmem yet?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature