Re: [Qemu-devel] [PATCH 4.5/7] glib: add compatibility interface for g_hash_table_add()

[Eric Blake]

On 10/27/2015 08:51 AM, Markus Armbruster wrote:
> The next commit will use it.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  include/glib-compat.h | 7 +++++++
>  1 file changed, 7 insertions(+)

One nit:

> 
> diff --git a/include/glib-compat.h b/include/glib-compat.h
> index fb25f43..5185630 100644
> --- a/include/glib-compat.h
> +++ b/include/glib-compat.h
> @@ -165,6 +165,13 @@ static inline GThread *g_thread_new(const char *name,
>  #define CompatGCond GCond
>  #endif /* glib 2.31 */
>  
> +#if !GLIB_CHECK_VERSION(2, 32, 0)
> +static inline gboolean g_hash_table_add (GHashTable *hash_table, gpointer 
> key)

Drop the space before (

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature