[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] virtio: introduce virtio_map
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/6] virtio: introduce virtio_map |
|
Date: |
Tue, 27 Oct 2015 16:19:54 +0000 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Tue, Oct 27, 2015 at 10:47:56AM +0200, Michael S. Tsirkin wrote:
> This will still fail if there's no space left in the sg, but luckily max
> queue size in use is currently 256, while max sg size is 1024, so we
> should be OK even is all entries happen to cross a single DIMM boundary.
Don't forget about indirect descriptors. They can use all 1024 iovecs,
regardless of virtqueue size, so virtqueue size of 256 isn't the true
maximum.
I'm worried that we could now see failures due to non-contiguous HVAs.