[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] qga: fixed CloseHandle in qmp_guest_file_op
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] qga: fixed CloseHandle in qmp_guest_file_open |
Date: |
Tue, 27 Oct 2015 19:14:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 |
Am 27.10.2015 um 18:48 schrieb Denis V. Lunev:
> From: Olga Krishtal <address@hidden>
>
> CloseHandle use HANDLE as an argument, but not *HANDLE
>
> Signed-off-by: Olga Krishtal <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Michael Roth <address@hidden>
> CC: Stefan Weil <address@hidden>
> ---
> qga/commands-win32.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/commands-win32.c b/qga/commands-win32.c
> index d9de23b..97f19d5 100644
> --- a/qga/commands-win32.c
> +++ b/qga/commands-win32.c
> @@ -160,7 +160,7 @@ int64_t qmp_guest_file_open(const char *path, bool
> has_mode,
>
> fd = guest_file_handle_add(fh, errp);
> if (fd < 0) {
> - CloseHandle(&fh);
> + CloseHandle(fh);
> error_setg(errp, "failed to add handle to qmp handle table");
> return -1;
> }
>
Reviewed-by: Stefan Weil <address@hidden>
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH 1/3] qga: drop hand-made guest_file_toggle_flags helper, Denis V. Lunev, 2015/10/27