qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/9] block: Fixes for bdrv_drain


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH 0/9] block: Fixes for bdrv_drain
Date: Wed, 28 Oct 2015 11:16:33 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

Am 26.10.2015 um 07:24 hat Fam Zheng geschrieben:
> Previously bdrv_drain and bdrv_drain_all don't handle ioctl, flush and discard
> requests (which are fundamentally the same as read and write requests that
> change disk state).  Forgetting such requests leaves us in risk of violating
> the invariant that bdrv_drain() callers rely on - all asynchronous requests
> must have completed after bdrv_drain returns.
> 
> Enrich the tracked request types, and add tracked_request_begin/end pairs to
> all three code paths. As a prerequisite, ioctl code is moved into coroutine
> too.
> 
> The last two patches take care of QED's "need check" timer, so that after
> bdrv_drain returns, the driver is in a consistent state.

Patches 1-3, 5-7 and 9:
Reviewed-by: Kevin Wolf <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]