[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/4] linux-user: manage bind with a socket of
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/4] linux-user: manage bind with a socket of SOCK_PACKET type. |
Date: |
Wed, 28 Oct 2015 20:09:23 +0000 |
On 28 October 2015 at 19:25, Laurent Vivier <address@hidden> wrote:
>
>
> Le 28/10/2015 20:20, Peter Maydell a écrit :
>> On 28 October 2015 at 19:13, Laurent Vivier <address@hidden> wrote:
>>> +static abi_long packet_target_to_host_addr(void *host_addr,
>>> + abi_ulong target_addr,
>>> + socklen_t len)
>>
>> Should the function name be ..._to_host_sockaddr ?
>
> It was what I did in my first draft, but as I have called the type
> TargetFdDataFunc and TargetFdAddrFunc, I have chosen to call the
> function _addr.
>
> If you think it is better, I can change that.
Well, it is sockaddr types we're handling, so it seems
a bit clearer to use that in the name.
thanks
-- PMM